Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inability to contact metrics server on forwarding #14505

Merged
merged 1 commit into from Jan 10, 2024
Merged

Handle inability to contact metrics server on forwarding #14505

merged 1 commit into from Jan 10, 2024

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Nov 3, 2023

Explain your changes:

  • Handle an error of contacting a metrics server requested by forward URI

Explain how you tested your changes:

  • Testing to be done

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@georgeee georgeee requested a review from a team as a code owner November 3, 2023 15:00
@georgeee georgeee changed the base branch from berkeley to rampup December 11, 2023 18:08
@georgeee georgeee requested review from a team as code owners December 11, 2023 18:08
@georgeee georgeee force-pushed the georgeee/handle-inability-to-contact-metrics-server-on-forwarding branch from 8e20488 to 9acdd89 Compare December 11, 2023 18:09
@georgeee
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

1 similar comment
@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar
Copy link
Member

!ci-build-me

@georgeee georgeee force-pushed the georgeee/handle-inability-to-contact-metrics-server-on-forwarding branch from 5af12b4 to 6446a4a Compare January 8, 2024 18:04
@georgeee
Copy link
Member Author

georgeee commented Jan 8, 2024

!ci-build-me

@georgeee georgeee force-pushed the georgeee/handle-inability-to-contact-metrics-server-on-forwarding branch from 6446a4a to 03861b5 Compare January 8, 2024 18:07
@georgeee
Copy link
Member Author

georgeee commented Jan 8, 2024

!ci-build-me

@georgeee georgeee force-pushed the georgeee/handle-inability-to-contact-metrics-server-on-forwarding branch from 03861b5 to 6896dce Compare January 9, 2024 11:41
@georgeee
Copy link
Member Author

georgeee commented Jan 9, 2024

!ci-build-me

@georgeee georgeee force-pushed the georgeee/handle-inability-to-contact-metrics-server-on-forwarding branch from 6896dce to 09c927f Compare January 10, 2024 10:18
@georgeee
Copy link
Member Author

!ci-build-me

@nholland94
Copy link
Member

!approved-for-mainnet

@georgeee georgeee merged commit 3b54253 into rampup Jan 10, 2024
36 checks passed
@georgeee georgeee deleted the georgeee/handle-inability-to-contact-metrics-server-on-forwarding branch January 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanabriaRusso SanabriaRusso SanabriaRusso approved these changes

@joaosreis joaosreis joaosreis approved these changes

@rbonichon rbonichon rbonichon approved these changes

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@deepthiskumar deepthiskumar deepthiskumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@georgeee @deepthiskumar @nholland94 @SanabriaRusso @joaosreis @rbonichon @MartinMinkov