Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use explict field to differentiate slot_since_genesis slot_since_hard_fork #14569

Merged
merged 10 commits into from
Dec 18, 2023

Conversation

ghost-not-in-the-shell
Copy link
Member

@ghost-not-in-the-shell ghost-not-in-the-shell commented Nov 16, 2023

Explain your changes:
This PR changes the field curr_global_slot to curr_global_slot_since_hard_fork in consensus_state. The purpose is to make it more clear that which kind of slot (since_genesis vs. since_hard_fork) is being used. It should not affect the usage of mainnet config.

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner November 16, 2023 21:13
@ghost-not-in-the-shell ghost-not-in-the-shell changed the title use explict field to differentiate slot_since_genesis and use explict field to differentiate slot_since_genesis slot_since_hard_fork Nov 16, 2023
@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member

Lints job failed -- needs to be fixed

This fix might break compatibility of berkeley with ITN, but this is probably fine.

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar
Copy link
Member

!ci-nightly-me

@coveralls
Copy link

coveralls commented Dec 18, 2023

Coverage Status

coverage: 61.527%. first build
when pulling 6ef4d10 on global-slot-json-format
into 16bd00b on berkeley.

@ghost-not-in-the-shell ghost-not-in-the-shell merged commit d3642cb into berkeley Dec 18, 2023
47 checks passed
@ghost-not-in-the-shell ghost-not-in-the-shell deleted the global-slot-json-format branch December 18, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants