-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use explict field to differentiate slot_since_genesis slot_since_hard_fork #14569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slot_since_hard_fork
ghost-not-in-the-shell
changed the title
use explict field to differentiate slot_since_genesis and
use explict field to differentiate slot_since_genesis slot_since_hard_fork
Nov 16, 2023
!ci-build-me |
!ci-build-me |
Lints job failed -- needs to be fixed This fix might break compatibility of |
georgeee
approved these changes
Nov 17, 2023
!ci-build-me |
!ci-build-me |
…a into global-slot-json-format
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!approved-for-mainnet |
!ci-nightly-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
This PR changes the field
curr_global_slot
tocurr_global_slot_since_hard_fork
inconsensus_state
. The purpose is to make it more clear that which kind of slot (since_genesis vs. since_hard_fork) is being used. It should not affect the usage of mainnet config.Explain how you tested your changes:
*
Checklist: