support ci on forks #14596
Merged
support ci on forks #14596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkijania
force-pushed
the
dkijania/support_ci_on_forks
branch
from
64bd235
to
a4ddb79
Compare
buildkite/src/Monorepo.dhall
Outdated
| @@ -28,6 +28,7 @@ let jobs : List JobSpec.Type = | |||
| let prefixCommands = [ | |||
| Cmd.run "git config --global http.sslCAInfo /etc/ssl/certs/ca-bundle.crt", -- Tell git where to find certs for https connections | |||
| Cmd.run "git fetch origin", -- Freshen the cache | |||
There was a problem hiding this comment.
Would this fetch be unnecessary when executing pipelines for a fork? If not required I would add a condition here. It would save us the burden to download the ~450MB repo.
dkijania
force-pushed
the
dkijania/support_ci_on_forks
branch
from
83c6e76
to
5eb0f91
Compare
SanabriaRusso
approved these changes
Nov 22, 2023
7 tasks
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our CI build system is not prepared to handle change from fork repo to mina. There are various problems like:
many jobs checkout origin branches as reference to some comparison and they will checkout branch from fork repo rather than mina (for example merges cleanly)
we should not allow to publish dockers to docker hub from forked repositories
we need to tag dockers properly not to override main repo based dockers
This PR addresses above problems. It adds yet another remote (mina) which always point to mina protocol repository. If CI is run against forked repository it uses branches from mina remote for comparison instead of origin which point to forked repositories. It also changes behavior when running export env variables script. It does not allow to publish dockers and debian packages stable channels or to dockerhub.
Closes #14575