Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/archive db add indexes #14792

Merged
merged 4 commits into from Jan 6, 2024
Merged

Fix/archive db add indexes #14792

merged 4 commits into from Jan 6, 2024

Conversation

ghost-not-in-the-shell
Copy link
Member

@ghost-not-in-the-shell ghost-not-in-the-shell commented Jan 5, 2024 •
edited

Explain your changes:
This PR adds 2 indexes to archive database which helps to optimize the speed of archiving max cost zkapps.

To patch the existing database, please use add_indexes.sql

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner January 5, 2024 19:16
@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

MartinMinkov
MartinMinkov approved these changes Jan 5, 2024
View reviewed changes
src/app/archive/zkapp_tables.sql
@@ -81,6 +83,9 @@ CREATE TABLE zkapp_events
, element_ids int[] NOT NULL
);

CREATE INDEX idx_zkapp_events_element_ids ON zkapp_events(element_ids);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, extra spaces here? 😅

@bkase
Copy link
Member

bkase commented Jan 5, 2024

!approved-for-mainnet

@bkase
Copy link
Member

bkase commented Jan 5, 2024

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@bkase
Copy link
Member

bkase commented Jan 5, 2024

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit c70bc52 into rampup Jan 6, 2024
27 checks passed
@deepthiskumar deepthiskumar deleted the fix/archive-db-add-indexes branch January 6, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ghost-not-in-the-shell @bkase @MartinMinkov @deepthiskumar