Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive/fix add genesis accounts #15504

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Archive/fix add genesis accounts #15504

merged 5 commits into from
Apr 12, 2024

Conversation

ghost-not-in-the-shell
Copy link
Member

@ghost-not-in-the-shell ghost-not-in-the-shell commented Apr 10, 2024 •
edited

Explain your changes:
This PR fixes archive node that crashes on the new fork genesis config file. The fix is simply to let the archive to read the ledger file directly from the precomputed_values.

Explain how you tested your changes:
Tested with devnet archive node by passing devnet genesis config.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner April 10, 2024 20:02
@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell ghost-not-in-the-shell requested a review from a team as a code owner April 11, 2024 16:50
@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Member Author

!ci-build-me

@ghost-not-in-the-shell ghost-not-in-the-shell mentioned this pull request Apr 11, 2024
Merged
7 tasks
@mrmr1993
Copy link
Member

!approved-for-mainnet

@ghost-not-in-the-shell ghost-not-in-the-shell merged commit 0981677 into berkeley Apr 12, 2024
39 checks passed
@ghost-not-in-the-shell ghost-not-in-the-shell deleted the archive/fix-add-genesis-accounts branch April 12, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emberian emberian emberian approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@dkijania dkijania dkijania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ghost-not-in-the-shell @mrmr1993 @emberian @dkijania