Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't use step feature_flags for wrap evaluations #15588

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

mrmr1993
Copy link
Member

This PR fixes o1-labs/o1js#1336 (using o1-labs/o1js#1335 as the repro case).

The underlying issue was that we were using the feature flags for the step circuit when reasoning about the contents of the wrap proofs. In particular,

  • when the circuit uses a feature
  • and it uses recursion
  • then it expects that feature to be used by the wrap proof that it recurses over (even though wrap never uses any custom gates).

This PR fixes that by hard-coding Features.Full.none.

@mrmr1993 mrmr1993 requested a review from a team as a code owner April 30, 2024 09:29
@dannywillems
Copy link
Member

!ci-build-me

@mrmr1993 mrmr1993 merged commit 56c1726 into develop Apr 30, 2024
40 checks passed
@mrmr1993 mrmr1993 deleted the fix/wrap-recursion-features branch April 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursion fails in ECDSA circuit
2 participants