Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use public library names #15631

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Use public library names #15631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a1a934
Use public names for library deps
georgeee May 5, 2024
07f933e
Add public_name to mina_base_test_helpers library
georgeee May 8, 2024
100a3ae
Do not use private lib names outside package
georgeee May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/app/berkeley_migration/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
archive_lib
block_time
consensus
consensus_vrf
consensus.vrf
currency
genesis_constants
genesis_ledger_helper
Expand All @@ -39,11 +39,12 @@
mina_wire_types
one_or_two
protocol_version
runtime_config
mina_runtime_config
signature_lib
unsigned_extended
with_hash
cli_lib
mina_version
)
(preprocessor_deps ../../config.mlh)
(instrumentation (backend bisect_ppx))
Expand Down
4 changes: 2 additions & 2 deletions src/app/berkeley_migration_verifier/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
archive_lib
block_time
consensus
consensus_vrf
consensus.vrf
currency
genesis_constants
genesis_ledger_helper
Expand All @@ -39,7 +39,7 @@
mina_wire_types
one_or_two
protocol_version
runtime_config
mina_runtime_config
signature_lib
unsigned_extended
with_hash
Expand Down
2 changes: 1 addition & 1 deletion src/app/disk_caching_stats/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
(name disk_caching_stats)
(libraries pickles pickles_types pickles.backend snark_params crypto_params network_pool mina_base
signature_lib one_or_two currency ledger_proof mina_state mina_base.import mina_wire_types
mina_numbers random_oracle random_oracle_input kimchi_pasta_basic data_hash_lib with_hash
mina_numbers random_oracle random_oracle_input kimchi_pasta.basic data_hash_lib with_hash
kimchi_pasta mina_ledger transaction_snark_scan_state mina_transaction_logic transaction_snark
sgn snark_profiler_lib genesis_constants digestif bigarray-compat
; --
Expand Down
2 changes: 1 addition & 1 deletion src/app/extract_blocks/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
uri
async.async_command
;; local libraries
consensus_vrf
consensus.vrf
mina_wire_types
bounded_types
mina_base
Expand Down
2 changes: 1 addition & 1 deletion src/app/ledger_export_bench/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
core_kernel
yojson
; mina libraries
runtime_config)
mina_runtime_config)
; the -w list here should be the same as in src/dune
(flags -short-paths -g -w @a-4-29-40-41-42-44-45-48-58-59-60)
(instrumentation (backend bisect_ppx))
Expand Down
2 changes: 1 addition & 1 deletion src/lib/block_producer/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
kimchi_pasta.basic
internal_tracing
mina_networking
runtime_config
mina_runtime_config
)
(preprocess
(pps ppx_mina ppx_version ppx_jane ppx_register_event))
Expand Down
2 changes: 1 addition & 1 deletion src/lib/crypto/kimchi_backend/gadgets/runner/example/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@
promise
kimchi_backend_common
ppx_version.runtime
kimchi_gadgets_test_runner
kimchi_backend.gadgets_test_runner
))
2 changes: 1 addition & 1 deletion src/lib/crypto/kimchi_bindings/js/test/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
kimchi_backend_common
kimchi_pasta
kimchi_pasta.basic
kimchi_pasta_constraint_system
kimchi_pasta.constraint_system
mina_metrics.none
run_in_thread.fake
snarky.backendless
Expand Down
2 changes: 1 addition & 1 deletion src/lib/crypto/kimchi_bindings/js/test/nodejs/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
pasta_bindings
js_of_ocaml
bindings_js
node_backend
bindings_js.node_backend
logger.fake
pasta_bindings.backend.none)
(link_deps ../../node_js/plonk_wasm.js ../../node_js/plonk_wasm_bg.wasm)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/crypto/kimchi_bindings/js/test/web/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
kimchi_bindings
js_of_ocaml
bindings_js
web_backend
bindings_js.web_backend
logger.fake
pasta_bindings.backend.none)
(link_deps ../../web/plonk_wasm.js ../../web/plonk_wasm_bg.wasm)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/crypto/snarky_tests/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
kimchi_backend
kimchi_pasta
kimchi_pasta.basic
kimchi_pasta_constraint_system
kimchi_pasta.constraint_system
bitstring_lib
snarky.intf
pickles.backend
Expand Down
2 changes: 1 addition & 1 deletion src/lib/integration_test_cloud_engine/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
file_system
pickles
pickles_types
backend
pickles.backend
kimchi_pasta
kimchi_pasta.basic
with_hash
Expand Down
2 changes: 1 addition & 1 deletion src/lib/integration_test_local_engine/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
file_system
pickles
pickles_types
backend
pickles.backend
kimchi_pasta
kimchi_pasta.basic
with_hash
Expand Down
2 changes: 1 addition & 1 deletion src/lib/ledger_catchup/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@
o1trace
mina_net2
internal_tracing
runtime_config
mina_runtime_config
))
1 change: 1 addition & 0 deletions src/lib/mina_base/test/helpers/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
(library
(public_name mina_base.test_helpers)
(name mina_base_test_helpers)
(libraries
;; opam libraries
Expand Down
2 changes: 1 addition & 1 deletion src/lib/mina_ledger/test/helpers/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
kimchi_pasta
kimchi_pasta.basic
mina_base
mina_base_test_helpers
mina_base.test_helpers
mina_ledger
mina_numbers
monad_lib
Expand Down
2 changes: 1 addition & 1 deletion src/lib/mina_lib/tests/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
block_time
pipe_lib
signature_lib
runtime_config
mina_runtime_config
trust_system
protocol_version
transition_frontier_base
Expand Down
2 changes: 1 addition & 1 deletion src/lib/network_pool/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
kimchi_backend_common
kimchi_pasta
kimchi_pasta.basic
genesis_ledger
coda_genesis_ledger
staged_ledger_diff
mina_wire_types
)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/network_pool/test/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
data_hash_lib
genesis_constants
bounded_types
genesis_ledger
coda_genesis_ledger
logger
mina_base
mina_base.import
Expand Down
2 changes: 1 addition & 1 deletion src/lib/o1js_stub/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
bindings_js
integers_stubs_js
zarith_stubs_js
node_backend
bindings_js.node_backend
;; js-specific overrides ;;
cache_dir.fake
digestif.ocaml
Expand Down
1 change: 0 additions & 1 deletion src/lib/pickles/test/chunked_circuits/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
sponge
pickles
pickles.pseudo
composition_types
pickles.limb_vector
pickles_base
kimchi_backend
Expand Down
1 change: 0 additions & 1 deletion src/lib/pickles/test/optional_custom_gates/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
sponge
pickles
pickles.pseudo
composition_types
pickles.limb_vector
pickles_base
kimchi_backend
Expand Down
1 change: 0 additions & 1 deletion src/lib/pickles/test/optional_custom_gates/test_gadgets/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
sponge
pickles
pickles.pseudo
composition_types
pickles.limb_vector
pickles_base
kimchi_backend
Expand Down
2 changes: 1 addition & 1 deletion src/lib/snark_worker/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
mina_compile_config
mina_state
transaction_protocol_state
ppx_version_runtime
ppx_version.runtime
)
(preprocess
(pps
Expand Down
2 changes: 1 addition & 1 deletion src/lib/staged_ledger/test/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
;; local libraries
genesis_constants
mina_base
mina_base_test_helpers
mina_base.test_helpers
mina_generators
mina_ledger
mina_ledger_test_helpers
Expand Down
2 changes: 1 addition & 1 deletion src/lib/test_genesis_ledger/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(library
(public_name test_genesis_ledger)
(name test_genesis_ledger)
(libraries genesis_ledger core_kernel genesis_constants)
(libraries coda_genesis_ledger core_kernel genesis_constants)
(preprocessor_deps "../../config.mlh")
(instrumentation (backend bisect_ppx))
(preprocess (pps ppx_version ppx_optcomp ppx_let)))
2 changes: 1 addition & 1 deletion src/lib/transaction_logic/test/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
bounded_types
mina_base
mina_base.import
mina_base_test_helpers
mina_base.test_helpers
mina_ledger
mina_ledger_test_helpers
mina_transaction
Expand Down
2 changes: 1 addition & 1 deletion src/lib/transaction_logic/test/transaction_logic/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
kimchi_pasta.basic
mina_base
mina_base.import
mina_base_test_helpers
mina_base.test_helpers
mina_transaction
mina_transaction_logic
mina_numbers
Expand Down
4 changes: 2 additions & 2 deletions src/lib/transaction_snark/test/account_timing/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
transaction_snark
snark_params
data_hash_lib
genesis_proof
coda_genesis_proof
bounded_types
mina_ledger
mina_base
Expand All @@ -42,7 +42,7 @@
test_util
consensus
one_or_two
genesis_ledger
coda_genesis_ledger
snarky.backendless
mina_transaction_logic
mina_wire_types
Expand Down
2 changes: 1 addition & 1 deletion src/lib/transaction_snark/test/transaction_union/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
test_util
consensus
one_or_two
genesis_ledger
coda_genesis_ledger
sexplib0
quickcheck_lib
mina_transaction
Expand Down
4 changes: 2 additions & 2 deletions src/lib/transition_frontier/tests/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
consensus
data_hash_lib
block_time
full_frontier
frontier_base
transition_frontier_full_frontier
transition_frontier_base
transition_frontier
protocol_version
yojson
Expand Down
2 changes: 1 addition & 1 deletion src/lib/transition_handler/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
internal_tracing
transition_frontier_extensions
staged_ledger_diff
runtime_config
mina_runtime_config
)
(instrumentation (backend bisect_ppx))
(preprocess (pps ppx_mina ppx_version ppx_jane)))
2 changes: 1 addition & 1 deletion src/lib/vrf_lib/tests/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
snarky.backendless
bitstring_lib
crypto_params
backend
pickles.backend
kimchi_backend
kimchi_bindings
kimchi_types
Expand Down