Package generation/fix tarball #15659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-nightly-me |
ghost-not-in-the-shell
force-pushed
the
package-generation/fix-tarball
branch
from
19b2991
to
a980e1c
Compare
dkijania
reviewed
May 16, 2024
| @@ -325,6 +325,7 @@ module Ledger = struct | |||
| ; ("path", `String tar_path) | |||
| ; ("dir", `String dirname) | |||
| ] ; | |||
| let%bind () = after (Time.Span.of_int_sec 5) in | |||
There was a problem hiding this comment.
A comment would be nice why 5 seconds?
dkijania
reviewed
May 16, 2024
| @@ -101,7 +101,7 @@ let hardforkPipeline : DebianVersions.DebVersion -> Pipeline.Config.Type = | |||
| [ Command.build Command.Config::{ | |||
| commands = [ | |||
| Cmd.runInDocker Cmd.Docker::{ | |||
| image = "\\\${MINA_DAEMON_DOCKER_IMAGE:-gcr.io/o1labs-192920/mina-daemon@sha256:6da66879aacab050a6955c84347f587e43044987b04b9de4522a942f770cc5e7}" | |||
| image = "\\\${MINA_DAEMON_DOCKER_IMAGE:-gcr.io/o1labs-192920/mina-daemon:3.0.1-migration-tooling-package-generation-fix-tarball-a980e1c-bullseye-mainnet-hardfork}" | |||
There was a problem hiding this comment.
A comment would be nice why we are hardcoding daemon version
dkijania
approved these changes
May 16, 2024
|
!ci-build-me |
…generation/fix-tarball
|
!ci-build-me |
Merged
7 tasks
mrmr1993
approved these changes
May 22, 2024
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
Wait 5s before we create the tarball
Explain how you tested your changes:
I started a build on this branch with mainnet fork config: https://buildkite.com/o-1-labs-2/hardfork-package-generation/builds/335
Checklist: