Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalizing snarky yojson serializers to match kimchi common #15723

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

svv232
Copy link
Member

@svv232 svv232 commented Jun 6, 2024

Closes #12591

@svv232 svv232 requested review from a team as code owners June 6, 2024 16:36
@svv232
Copy link
Member Author

svv232 commented Jun 6, 2024

!ci-build-me

@@ -2,6 +2,7 @@ module Authorization_kind = struct
module V1 = struct
(* field for Proof is a verification key hash *)
type t = Signature | Proof of Snark_params.Tick.Field.t | None_given
[@@deriving yojson]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add this here; the wire_types library should only contain types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've reimplemented this solution to not do this

@svv232 svv232 requested a review from mrmr1993 June 10, 2024 16:28
@svv232
Copy link
Member Author

svv232 commented Jun 10, 2024

!ci-build-me

1 similar comment
@svv232
Copy link
Member Author

svv232 commented Jun 24, 2024

!ci-build-me

@svv232
Copy link
Member Author

svv232 commented Jul 3, 2024

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add yojson serializations to snarky
3 participants