Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local filesystem and rest-server modes for accounts import, accounts list #7282

Merged
merged 5 commits into from Apr 21, 2021

Conversation

mrmr1993
Copy link
Member

This PR

  • adds support importing keys to a remote daemon via GraphQL
  • reports when importing keys occurs locally due to a connection failure
  • allows setting of either -config-directory for explicit local imports or -rest-port for explicit remote imports
  • adds support (and fallthrough) for local account listing.

Some sample runs:

  • accounts list, no running daemon, imported keys
    Screenshot from 2020-12-30 23-46-19
  • accounts list, running daemon, no imported key
    Screenshot from 2020-12-30 23-51-23
  • accounts import, no running daemon, imported keys
    Screenshot from 2020-12-30 23-45-14
  • accounts import, running daemon, no imported key
    Screenshot from 2020-12-30 23-47-35
  • accounts list, running daemon, imported key
    Screenshot from 2020-12-30 23-48-21
  • accounts list, explicit config directory path
    Screenshot from 2020-12-30 23-49-06
  • accounts list with incompatible flags
    Screenshot from 2020-12-30 23-50-21

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #6110
Closes #7272
Closes #7273

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Dec 30, 2020
@mrmr1993 mrmr1993 requested review from a team as code owners December 30, 2020 23:52
@bkase bkase added this to Discuss in MainNet Jan 4, 2021
@mrmr1993 mrmr1993 changed the base branch from develop to compatible January 13, 2021 01:57
@aneesharaines aneesharaines moved this from Discuss to In Review in MainNet Jan 19, 2021
@mrmr1993 mrmr1993 linked an issue Mar 10, 2021 that may be closed by this pull request
@mrmr1993 mrmr1993 force-pushed the feature/accounts-import-consistent branch from 8459d98 to 356759f Compare April 20, 2021 15:10
Copy link
Member

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual QA, LGTM!

@mrmr1993 mrmr1993 merged commit 6d2d928 into compatible Apr 21, 2021
@mrmr1993 mrmr1993 deleted the feature/accounts-import-consistent branch April 21, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
MainNet
In Review
3 participants