Proposal implementation: Min window grace period #7504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost-not-in-the-shell
approved these changes
Jan 15, 2021
imeckler
force-pushed
the
min-window-grace-period
branch
from
77a719e
to
801ce0e
Compare
imeckler
added
the
ci-build-me
imeckler
added
ready-to-merge-into-develop
and removed
ready-to-merge-into-develop
labels
|
!approved-for-mainnet |
lk86
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR constitutes a proposal that we not take the min for min-window density during the initial days of the network. Specifically, it proposes we forgo updating the min density for the first 10 days (or epoch, whichever comes first) of the network's operation. The reasoning is as follows:
gets their nodes up and running. 10 days gives all involved in the project
a chance to observe the actual fill rate and try to fix what's keeping it down.
which means the long fork rule will not come into play during the grace period,
and then we still have 4 days (= 1920 slots) to compute min-density for the next epoch.
Testing
In addition to the unit tests which ensure the in-snark and out-of-snark versions agree, I ran a local network with this and observed the grace period working.