Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create CI dhall components for building and caching the test-executive and executing integration tests #7743

Merged
merged 44 commits into from
Feb 17, 2021
Merged

create CI dhall components for building and caching the test-executive and executing integration tests #7743

merged 44 commits into from
Feb 17, 2021

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Feb 1, 2021 •
edited

Also increase Buildkite agent cluster capacity to handle increased CI load and add artifact caching helper script to temporarily address #7745.

Test: Buildkite CI

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@O1ahmad O1ahmad requested a review from a team as a code owner February 1, 2021 18:14
@O1ahmad O1ahmad changed the base branch from develop to compatible February 1, 2021 18:14
@O1ahmad O1ahmad requested a review from a team February 1, 2021 18:15
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 1, 2021
O1ahmad
O1ahmad commented Feb 1, 2021
View reviewed changes
buildkite/src/Command/ExecuteIntegrationTest.dhall Outdated
Command.Config::{
commands = [
Cmd.run (
"if [ ! -f ${deployEnv} ]; then " ++
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #7745 to address DRY'ing this code up a bit

@O1ahmad O1ahmad changed the title create CI dhall components for building and caching test-executives and executing integration tests create CI dhall components for building and caching the test-executive and executing integration tests Feb 1, 2021
O1ahmad
O1ahmad commented Feb 1, 2021
View reviewed changes
buildkite/src/Jobs/Test/TestnetIntegrationTests.dhall Outdated
JobSpec::{
dirtyWhen = [
S.strictlyStart (S.contains "src"),
S.strictlyStart (S.contains "src/app/test-executive"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@O1ahmad O1ahmad mentioned this pull request Feb 5, 2021
Closed
5 tasks
lk86
lk86 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the existing comments, a makefile directive definitely seems worthwhile

@O1ahmad O1ahmad merged commit 142400a into compatible Feb 17, 2021
@O1ahmad O1ahmad deleted the ci_integration_test branch February 17, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@O1ahmad @lk86 @ghost-not-in-the-shell @nholland94