Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add variable artifact_path to ci deploy job #7744

Merged
merged 4 commits into from Feb 4, 2021
Merged

add variable artifact_path to ci deploy job #7744

merged 4 commits into from Feb 4, 2021

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Feb 1, 2021

May be worth adding artifact path as an input variable to the command (though that would make 4 params which feels like a lot).

Test: Buildkite CI

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@O1ahmad O1ahmad requested a review from a team as a code owner February 1, 2021 18:31
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 1, 2021
AryehAlexander
AryehAlexander approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@AryehAlexander AryehAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@O1ahmad O1ahmad changed the base branch from develop to compatible February 4, 2021 00:50
@O1ahmad O1ahmad requested review from a team as code owners February 4, 2021 00:50
@O1ahmad O1ahmad force-pushed the var_artifact_path_for_deploy branch from a7292a2 to 6bf07c6 Compare February 4, 2021 00:55
@O1ahmad O1ahmad merged commit f6b136e into compatible Feb 4, 2021
@O1ahmad O1ahmad deleted the var_artifact_path_for_deploy branch February 4, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

@AryehAlexander AryehAlexander AryehAlexander approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@O1ahmad @lk86 @AryehAlexander