Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check GraphQL schema in CI #7842

Merged
merged 10 commits into from Mar 22, 2021
Merged

Check GraphQL schema in CI #7842

merged 10 commits into from Mar 22, 2021

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Feb 6, 2021

This adds a buildkite job to check that our GraphQL schema is up-to-date. This would have prevented #7838, as well as all of the other times the schema has become mismatched.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 6, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner February 6, 2021 17:00
@mrmr1993 mrmr1993 changed the base branch from develop to compatible February 6, 2021 17:28
Copy link
Contributor

@O1ahmad O1ahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth temporarily modifying a file under src to verify the job and dependencies.

@aneesharaines
Copy link
Contributor

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit 76ff5ca into compatible Mar 22, 2021
@mrmr1993 mrmr1993 deleted the feature/check-graphql-ci branch March 22, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants