Missing subchain, fail when no chain with start block #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
mrmr1993
approved these changes
Feb 16, 2021
psteckler
added
ci-build-me
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If given a start block that didn't exist, or there was an unparented block between the start and end blocks,
missing_subchainwould yield a chain only as far back as the first unparented block, when searching backwards from the end block. The user was none the wiser.Instead, fail in those cases.
Tested on a Rosetta-generated archive db, by creating an unparented block in the middle of what was a chain between the start and end blocks.
Closes #7911.