[Hotfix]use production build profile for the archive binary #8091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthiskumar
added
the
ci-build-me
mrmr1993
requested changes
Mar 2, 2021
Makefile
Outdated
| @@ -83,7 +83,7 @@ build: git_hooks reformat-diff libp2p_helper | |||
|
|
|||
| build_archive: git_hooks reformat-diff | |||
| $(info Starting Build) | |||
| ulimit -s 65532 && (ulimit -n 10240 || true) && dune build src/app/archive/archive.exe --profile=$(DUNE_PROFILE) | |||
| ulimit -s 65532 && (ulimit -n 10240 || true) && dune build src/app/archive/archive.exe --profile=testnet_postake_medium_curves | |||
There was a problem hiding this comment.
Can you change the profiles in the CI jobs instead? This will clobber the build artifacts when using this during development.
There was a problem hiding this comment.
I think the change in 4d26dac should do
…ina into fix/archive-build-profile
|
Tested on one of our archive nodes (archive1) and blocks (with snarks in them) are getting added. Also verified that coinbase amount in the database is 720 |
O1ahmad
approved these changes
Mar 3, 2021
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUNE_PROFILE is not being set when building the archive.exe causing versioning mismatch between daemon and the archive process.
Fixes #8082
Fixes #8080