-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOTFIX] Genesis ledger generator for mainnet #8168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
Add this label to trigger a circle+buildkite build for this branch
label
Mar 8, 2021
I wonder if we should land this as a hotfix into master. Here's why:
|
bkase
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good
psteckler
force-pushed
the
feature/genesis-ledger-for-mainnet
branch
from
March 8, 2021 23:32
19a43d1
to
f8c330a
Compare
psteckler
changed the title
Genesis ledger generator for mainnet
[HOTFIX] Genesis ledger generator for mainnet
Mar 8, 2021
This feels morally okay for me to approve for mainnet as I described above |
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the program to generate the genesis ledger JSON from a tab-separated-values dump of the ledger spreadsheet.
For testnets, the program used dummy keys for accounts we didn't yet have keys for. Here, all accounts must have valid keys. If keys are missing or otherwise invalid, there will be a validation error, and there won't be any JSON output.
Also added another validation and optimization. If the cliff amount and unlock amount are zero, check that the initial min balance is also zero, otherwise that balance will never vest. When the JSON is generated, omit the timing if the cliff amount and unlock amount are both zero.
And allow floats for the
cliff_time_months
column. When calculating the number of slots that represents, round up, if it's a fractional number of slots.Tested against a testnet ledger where the accounts with pending keys were removed (to see if it succeeded), and against a testnet ledger with pending keys in place (to see if there were validation errors).