Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Fix mina demo dockerfile and container #8175

Merged
merged 5 commits into from
Mar 12, 2021

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Mar 9, 2021

Fix demo keys in Dockerfile-rosetta and Dockerfile-coda-demo, update build-rosetta-stages script with opam_branch and mina_branch awareness

  • Fixes demo keys in Dockerfile-rosetta
  • Fixes Dockerfile-coda-demo
  • updates build-rosetta-stages script with opam_branch and mina_branch awareness

…erfile-rosetta and Dockerfile-coda-demo, update build-rosetta-stages script with opam_branch and mina_branch awareness
@lk86 lk86 requested review from a team as code owners March 9, 2021 02:53
@lk86 lk86 changed the base branch from develop to master March 9, 2021 02:53
@lk86 lk86 changed the title Fix minaa demo dockerfile and container [HOTFIX] Fix mina demo dockerfile and container Mar 9, 2021
lk86 added a commit that referenced this pull request Mar 9, 2021
… in Dockerfile-rosetta and Dockerfile-coda-demo, update build-rosetta-stages script with opam_branch and mina_branch awareness"

This reverts commit 3648d75, see #8175 for this commit in its new home.
@@ -5,8 +5,8 @@ set -e
genesis_time=$(date -d "$(mina advanced compile-time-constants | jq -r '.genesis_state_timestamp')" +%s)
now_time=$(date +%s)

export CODA_TIME_OFFSET=$(( $now_time - $genesis_time ))
export CODA_TIME_OFFSET=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we need this to start from genesis block even on a build that sets genesis time long in the past

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these builds set genesis time to like, yesterday, so the complexity here shouldn't be needed, and it was producing a negative value and therefore never producing blocks when figment was testing with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed change to rewriting the genesis timestamp in the config file instead of dealing with this time math and relying on constants in the genesis ledger / this environment variable. While i'm in there i will also remove depencencies on these environment variables and switch to flags so this doesn't break in future releases.

…n for Dockerfile-coda-demo and Dockerfile-rosetta
@lk86 lk86 requested a review from bkase March 11, 2021 01:02
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, ship it

@bkase bkase added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 11, 2021
@imeckler
Copy link
Member

!approved-for-mainnet

@imeckler imeckler merged commit b96dfea into master Mar 12, 2021
@imeckler imeckler deleted the hotfix/fix-coda-demo-and-rosetta-dockerfiles branch March 12, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants