-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOTFIX] Fix mina demo dockerfile and container #8175
[HOTFIX] Fix mina demo dockerfile and container #8175
Conversation
…erfile-rosetta and Dockerfile-coda-demo, update build-rosetta-stages script with opam_branch and mina_branch awareness
…o-and-rosetta-dockerfiles
@@ -5,8 +5,8 @@ set -e | |||
genesis_time=$(date -d "$(mina advanced compile-time-constants | jq -r '.genesis_state_timestamp')" +%s) | |||
now_time=$(date +%s) | |||
|
|||
export CODA_TIME_OFFSET=$(( $now_time - $genesis_time )) | |||
export CODA_TIME_OFFSET=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we need this to start from genesis block even on a build that sets genesis time long in the past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these builds set genesis time to like, yesterday, so the complexity here shouldn't be needed, and it was producing a negative value and therefore never producing blocks when figment was testing with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed change to rewriting the genesis timestamp in the config file instead of dealing with this time math and relying on constants in the genesis ledger / this environment variable. While i'm in there i will also remove depencencies on these environment variables and switch to flags so this doesn't break in future releases.
…n for Dockerfile-coda-demo and Dockerfile-rosetta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, ship it
!approved-for-mainnet |
Fix demo keys in Dockerfile-rosetta and Dockerfile-coda-demo, update build-rosetta-stages script with opam_branch and mina_branch awareness