Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes chain id extraction for the seed peer metric #8258

Merged
merged 5 commits into from Mar 22, 2021

Conversation

deepthiskumar
Copy link
Member

Fixes the error Expecting property name enclosed in double quotes: line 1 column 2 (char 1) seen on mainnet watchdog pod.
The format of the string returned by mina client status --json is not recognized by the python json decoder. Requires keys to be in double quotes instead of single quotes that the command returns-

{'num_accounts': None, 'blockchain_length': None, 'highest_block_length_received': 1, 'highest_unvalidated_block_length_received': 0, 'uptime_secs': 240370, 'ledger_merkle_root': None, 'state_hash': None, 'chain_id': '5f704cc0c82e0ed70e873f0893d7e06f148524e3f0bdae2afb02e7819a0c24d1', ...

Tested by running the watchdog script locally and connecting to mainnet seeds

@es92
Copy link
Contributor

es92 commented Mar 15, 2021

Can you bump the version and do a make release for this too? It should be 0.4.5, there's already a 0.4.4 version update out

@deepthiskumar
Copy link
Member Author

pushed gcr.io/o1labs-192920/watchdog:0.4.5

@deepthiskumar deepthiskumar added ci-build-me Add this label to trigger a circle+buildkite build for this branch waiting-for-gating labels Mar 17, 2021
@bkase
Copy link
Member

bkase commented Mar 20, 2021

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit 46b02f1 into master Mar 22, 2021
@mrmr1993 mrmr1993 deleted the fix/chain-id-extract branch March 22, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch waiting-for-gating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants