Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Check public keys are valid before placing transactions in the pool #8442

Merged
merged 1 commit into from Mar 25, 2021
Merged

[HOTFIX] Check public keys are valid before placing transactions in the pool #8442

merged 1 commit into from Mar 25, 2021

Conversation

mrmr1993
Copy link
Member

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 24, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner March 24, 2021 20:12
@mrmr1993 mrmr1993 added this to In Review in MainNet Mar 24, 2021
@mrmr1993 mrmr1993 changed the title [master-qa] Check public keys are valid before placing transactions in the pool [hotfix] Check public keys are valid before placing transactions in the pool Mar 24, 2021
@mrmr1993 mrmr1993 changed the base branch from master-qa to master March 24, 2021 22:22
@mrmr1993 mrmr1993 changed the title [hotfix] Check public keys are valid before placing transactions in the pool [HOTFIX] Check public keys are valid before placing transactions in the pool Mar 24, 2021
@imeckler
Copy link
Member

!approved-for-mainnet

@bkase bkase merged commit a8893ab into master Mar 25, 2021
@bkase bkase deleted the feature/check-keys-in-pool branch March 25, 2021 01:22
@aneesharaines aneesharaines moved this from In Review to Done in MainNet Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeckler imeckler imeckler approved these changes

@deepthiskumar deepthiskumar Awaiting requested review from deepthiskumar

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
MainNet
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrmr1993 @imeckler @bkase