fix stackdriver log metric #8664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthiskumar
force-pushed
the
fix/alert-improvements
branch
from
1f06c77
to
c78abcb
Compare
deepthiskumar
added
the
ci-build-me
imeckler
approved these changes
Apr 21, 2021
deepthiskumar
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.fixed an issue where updating
Coda_watchdog_pods_with_no_new_logsmetric fails when there are evicted pods.2. Added
forclause to wait for 12 mins before triggering theWatchdogNoNewLogsalert. This is to wait for nodes to get back up when they crash. The metric is updated every 10 mins and hence the 12 mins wait time