Increase the missing log time period #8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
reviewed
Apr 28, 2021
imeckler
approved these changes
Apr 30, 2021
deepthiskumar
added
the
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WatchdogNoNewLogsmetric is getting triggered on devnet quite frequently because of less activity (see #8727). On mainnet this alert was getting triggered mainly due to nodes restarting which got fixed after adding theforclause.Changes:
forclause). There was a suggestion to move this to a warning but instead I increased the time period to 1 hour. Seemed ok if we missed a few minutes of logs and take a backup only if it became critical? (see the investigation section in the runbook)Tested by running the watchdog script locally
Closes #8727