Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable-alpha-builds #8876

Merged
merged 32 commits into from May 26, 2021
Merged

enable-alpha-builds #8876

merged 32 commits into from May 26, 2021

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented May 13, 2021

Clean up daemon entrypoint and test in preparation for alpha release, and update CI accordingly.

@lk86 lk86 requested a review from a team as a code owner May 13, 2021 05:28
@lk86 lk86 changed the base branch from develop to compatible May 13, 2021 05:29
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label May 13, 2021
@lk86 lk86 requested a review from a team as a code owner May 16, 2021 05:28
automation/terraform/modules/services/daemon/README.md Outdated Show resolved Hide resolved
buildkite/scripts/build-artifact.sh Outdated Show resolved Hide resolved
buildkite/scripts/connect-to-mainnet-on-compatible.sh Outdated Show resolved Hide resolved
dockerfiles/puppeteer-context/mina_daemon_puppeteer.py Outdated Show resolved Hide resolved
scripts/rebuild-deb.sh Outdated Show resolved Hide resolved
@@ -9,7 +9,7 @@
(libraries mina_cli_entrypoint)
(instrumentation (backend bisect_ppx))
(preprocess (pps ppx_version))
(flags -short-paths -g -w @a-4-29-40-41-42-44-45-48-58-59-60-66))
(flags -short-paths -w @a-4-29-40-41-42-44-45-48-58-59-60-66))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check with @mrmr1993 if we need the -g for the core-dumps or other data for debugging the memory errors?

@lk86 lk86 requested a review from mrmr1993 May 21, 2021 08:34
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once you check the -g with @mrmr1993

@lk86 lk86 requested review from a team as code owners May 25, 2021 19:07
@lk86 lk86 changed the base branch from compatible to release/1.1.6 May 25, 2021 21:08
@lk86 lk86 merged commit 35749be into release/1.1.6 May 26, 2021
@lk86 lk86 deleted the enable-alpha-builds branch May 26, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants