New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes network=mainnet work properly in Rosetta #8877
Conversation
@jspada is testing this against the new ledger build now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
mainnet
REQUEST = {"metadata": {}}
Getting network identifier... mainnet
RESPONSE = {"network_identifiers": [{"blockchain": "coda", "network": "mainnet"}]}
testnet
REQUEST = {"metadata": {}}
Getting network identifier... testnet
RESPONSE = {"network_identifiers": [{"blockchain": "coda", "network": "testnet"}]}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good; I haven't tested, so I'll assume that you or @jspada will.
Slightly different behaviour. In Brandon's previous fix it used to report In the new version of the fix it seems depend on what profile mina is built with (rather than rosetta) and reports
Is this the desired behaviour? |
When Rosetta is built with the mainnet profile, report (correctly) that the network being used in mainnet.