Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Don't look for genesis proof file at startup #8947

Merged
merged 1 commit into from May 26, 2021
Merged

[Release] Don't look for genesis proof file at startup #8947

merged 1 commit into from May 26, 2021

Conversation

mrmr1993
Copy link
Member

This PR stops calling into code for loading genesis proofs from file or S3. This removes a number of unnecessary log messages.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label May 25, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner May 25, 2021 19:17
@lk86 lk86 added this to In progress in United Sprint Board via automation May 25, 2021
@lk86 lk86 moved this from In progress to Review in progress in United Sprint Board May 25, 2021
@lk86 lk86 merged commit d0d1347 into release/1.1.6 May 26, 2021
@lk86 lk86 deleted the feature/no-genesis-proof-logs branch May 26, 2021 05:52
United Sprint Board automation moved this from Review in progress to Done May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
United Sprint Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrmr1993 @lk86