devnet catchup failure fix #8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeckler
approved these changes
May 27, 2021
deepthiskumar
added
the
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes crashed with the dangling merkle mask parent exception when one of them created a fork off of the root of the frontier.
This is an edge case in the catchup code where a cached breadcrumb becomes stale and doesn't get updated before being used. The breadcrumb at the root changes when the root transitions. When a node produces blocks off of the root of the frontier and other nodes try to catchup to the short fork, they’d use the stale breadcrumb which would have a detached mask.
Fixed by not storing any breadcrumbs in the catchup tree
Reproduced it locally and tested the fix
This is a different case from what is reported in #8681 which is the transition frontier and extension desync issue