Close stdin for some processes #9178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
Can you link to where this is done, for completeness? |
mrmr1993
approved these changes
Jul 9, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9163 suggests that there's a FIFO leak in the code. When child processes terminate, the Mina executable should close
stdin, its end of the pipe shared with those processes.For
libp2p, thestart_customcode already does a close on termination. For the SNARK worker and verifier, this PR introduces explicit closes.Tested that the code for the verifier is exercised by running a local network, killing the verifier, and printing out the closed status of all 3 file descriptors. Only the
stdinwas open. (Also verified that the closes for libp2p helper are being called. Probably the one for stdout isn't needed.)(In fact, in one case, all 3 descriptors remained open, but I'm supposing that's a race where the stdout and stderr had not yet been automatically closed.)