Delegation backend: new storage structure #9712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost-not-in-the-shell
added
the
ci-build-me
ghost-not-in-the-shell
approved these changes
Oct 27, 2021
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
ed1d9bf
to
9f0993d
Compare
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
9f0993d
to
b5e2326
Compare
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
5325131
to
23ddde4
Compare
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
a85f884
to
a194967
Compare
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
df34a13
to
a194967
Compare
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
a194967
to
ceb1421
Compare
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
2ec96ce
to
3ea6f55
Compare
* Store files at new paths * Implement a migration tool
Encode public key in correct way
Problem: migration tool is slow. Solution: try to improve the speed by allowing up to 100 concurrent migrations.
Problem: blocks are being overwritten again and again. This puts a substantial burden upon backend. Solution: do not overwrite existing objects on the bucket. In case of a block, that would result into block being uploaded only once.
georgeee
force-pushed
the
georgeee/delegation-backend-new-structure
branch
from
3ea6f55
to
9b806a3
Compare
mrmr1993
approved these changes
Apr 6, 2022
|
|
||
| const NETWORK_ID = 1 // mainnet | ||
| const PK_LENGTH = 33 // one field element (32B) + 1 bit (encoded as full byte) | ||
| const SIG_LENGTH = 64 // one field element (32B) and one scalar (32B) | ||
|
|
||
| // we use state hash code here, although it's not state hash |
There was a problem hiding this comment.
Can we use a different code here? The idea behind having separate ones was so that they were easy to distinguish / hard to confuse.
There was a problem hiding this comment.
It's complicated: it would require another round of data migration and some more action on Ontab's side. We might do it if we'll be doing such a pass for other reasons in future though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon request from OnTab, a few changes were introduced to Delegation backend. A different directory structure was agreed upon to ease implementation of Ontab's software.
Explain your changes:
<submited_date>/<submitted_time>-<submitter>.jsoncreated_at,submitterandblock_hashare added to the JSON filesubmitterfield is fixed to match Mina's standard Pk encoding (prefix was added)Explain how you tested your changes:
Checklist: