Prepare for OCaml 4.14 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mrmr1993
approved these changes
May 16, 2022
|
Thank you! Will try to make meaningful changes more apparent next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares
rpc_parallelto be compatible with thev14version of the Jane Street ecosystem (base, async, etc.) by merging upstreamv14and relaxing versions constraints. This is all needed in preparation for upgrading the whole ecosystem to OCaml 4.14 (see MinaProtocol/mina#10940)This has been tested to build as a drop-in replacement in the current Mina/compatible, modulo a variant renaming from
DisconnecttoConnection_closed