Bump min iOS version to 13 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-l-santos
approved these changes
Jan 2, 2023
p4checo
force-pushed
the
bump-min-ios-version-to-13
branch
from
7129cb0
to
bb6fc82
Compare
Codecov ReportBase: 95.92% // Head: 96.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 95.92% 96.04% +0.11%
==========================================
Files 100 100
Lines 5056 4976 -80
==========================================
- Hits 4850 4779 -71
+ Misses 206 197 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
## Changes - Bump iOS Deployment target to iOS 13 so that we can start using new features like Swift Concurrency without sprinkling `#if` blocks everywhere.
## Changes - Fix iOS 13 deprecations. - Remove `SecTrust` validation from `SecCertificate.publicKey()` extraction method, as the new `SecTrustEvaluateWithError` API checks against the keychain and validates expiration, which isn't relevant for public key extraction. It would also require regenerating new certificates every now and then for UTs, which we avoid via `SecTrustSetVerifyDate` on the `SecTrust.make` test helper. - Improve certificate generation documentation, configs and scripts as I went thru the process of generating new certificates before realizing that I didn't have to.
## Changes - Remove all deprecated iOS version checks and APIs, mostly iOS 11 in AlicerceAutoLayout. - Replace deprecated `PthreadLock` with iOS 16+ `AllocatedUnfairLock` in `Lock.`
p4checo
force-pushed
the
bump-min-ios-version-to-13
branch
from
bb6fc82
to
9620eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
features like Swift Concurrency without sprinkling
#ifblockseverywhere.
Description
SecTrustvalidation fromSecCertificate.publicKey()extraction method, as the new
SecTrustEvaluateWithErrorAPI checksagainst the keychain and validates expiration, which isn't relevant for
public key extraction. It would also require regenerating new
certificates every now and then for UTs, which we avoid via
SecTrustSetVerifyDateon theSecTrust.maketest helper.I went thru the process of generating new certificates before realizing
that I didn't have to.
AlicerceAutoLayout.
PthreadLockwith iOS 16+AllocatedUnfairLockinLock.