Create xToCenterX and xToCenterY AutoLayout Helpers
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes - `xToCenterY`: add new AutoLayout helpers for Y anchors (`top, bottom, firstBaseline` and `lastBaseline`) - `xToCenterX`: and new AutoLayout helpers to missing X anchors (`left` and `right`) - `Unit Tests`: add new UTs to cover newly added helpers
pedro-l-santos
force-pushed
the
feature/x-to-center-x-and-y-to-center-y-autolayout-helpers
branch
from
4457278
to
48351d9
Compare
Codecov ReportBase: 95.87% // Head: 95.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 95.87% 95.92% +0.04%
==========================================
Files 100 100
Lines 4996 5056 +60
==========================================
+ Hits 4790 4850 +60
Misses 206 206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pedro-l-santos
deleted the
feature/x-to-center-x-and-y-to-center-y-autolayout-helpers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Currently Alicerce's AutoLayout helpers only provide a
centerYToXvariant for each of the respective anchors, with the correspondingxToCenterYAPIs missing for said anchors. The same applies to somecenterXAPIs. While this doesn't limit the creation of constraints, it forces a view inversion when defining constraints, in order to define those particular constraints. This piece of work aims to implement these missing helpers in order to improve this.Description
Changes
xToCenterY: add new AutoLayout helpers for Y anchors:topbottomfirstBaselinelastBaselinexToCenterX: and new AutoLayout helpers to missing X anchors:leftrightUnit Tests: add new UTs to cover newly added helpers