Added support for JsonRequired, JsonProperty and StringLength #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sonPropertyAttribute, fixed l10n issue in tests regarding DateTime
Added JsonRequiredAttribute, StringLengthAttribute and UseDataAnnotationAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I need to serialize complex objects to CSV and need the possibility of altering column-names as well as mark properties as required or limit the maximum length of strings, I added support for JsonRequiredAttribute, JsonPropertyAttribute and StringLengthAttribute to this awesome package.
I tried to maintain the overall structure of this project by introducing UseDataAnnotationAttributes (defaults to true) as well as adding new test cases.
As this is the first time, I am trying to contribute to a project hosted on GitHub, I sincerely ask for a review, feedback and eventually accepting my pull request leading to a new version published to the NuGet Gallery.
I assume, the versioning tasks takes place at your end.
Oh, also I fixed a spelling mistake in your copyright. ;-)