Improving support for HC thermostats #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for hc modes * Add support for cooling temperature
|
No, there is no way to release this Beta. The change looks sensible to me but I have no way of testing cooling, since my thermostats are heating only. |
|
Going to blind merge and wait for the screams as I also have no way of testing... |
|
Thank you. I installed the new version and it works like a charm. Please ping me if any issues are reported - I can help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving support for HC (Heating/Cooling) thermostats
* Add support for hc modes
* Add support for cooling temperature
I've tested the change extensively on my setup with multiple HC.
What is the safe to do? Is there a way to release this to Beta?