Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing in raygun options #4

Merged
merged 5 commits into from
Aug 9, 2016
Merged

allow passing in raygun options #4

merged 5 commits into from
Aug 9, 2016

Conversation

jakesjews
Copy link

Allow passing in options to forward to raygun's initialization.

@nikz
Copy link
Contributor

nikz commented Feb 19, 2016

@jakesjews hi! Thanks, this looks awesome - would you mind adding a quick sanity test?

@jakesjews
Copy link
Author

No problem

@nikz
Copy link
Contributor

nikz commented Feb 19, 2016

Great, ping me if you have any issues!

@jakesjews
Copy link
Author

@nikz I added a test which passes locally but it looks like one of the four ember try scenarios is failing. I'm not quite sure how to go about debugging it.

@jakesjews
Copy link
Author

jakesjews commented Jul 26, 2016

I wasn't able to run the tests with the older packages anymore so I upgraded the project to Ember-CLI 2.7. I also merged with the latest changes on master.

@jakesjews
Copy link
Author

@nikz Is there anything else I need to do for this PR?

@nikz
Copy link
Contributor

nikz commented Aug 4, 2016

@jakesjews sorry, looks like it's out of date again :( Can you rebase/update to the latest master?

@jakesjews
Copy link
Author

@nikz no problem

@jakesjews
Copy link
Author

@nikz I'm all merged up but its pretty tough to rebase since I've merged with upstream a few different times over the past few months. Can we merge it with the commits or would you like me to make a new PR?

@nikz
Copy link
Contributor

nikz commented Aug 9, 2016

@jakesjews no problems :) Thanks!

@nikz nikz merged commit fb2ba5a into MindscapeHQ:master Aug 9, 2016
@jakesjews
Copy link
Author

awesome thanks a bunch!

@jakesjews jakesjews mentioned this pull request Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants