-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the app engine support #3
base: master
Are you sure you want to change the base?
Conversation
Hi there, Apologies for the delay in looking at this, just have time now. Looks like we have some build breaks on Travis:
Aside from the errors, the proposed imports for the appengine package may not be so appropriate for a common library such as this - GAE would certainly be a popular target and we definitely want to support this out of the box, however raygun4go can be run on other environments which are not that PaaS. For this reason if we could avoid taking a hard dependency on appengine that would be great. The dependency introduces maintenance issues which we must take into account. In our other providers we usually reference common functionality then create a specific implementation package for each platform - for instance https://github.com/MindscapeHQ/raygun4net and https://github.com/MindscapeHQ/raygun4java, the latter of which has a custom RaygunServletClient instead of the default RaygunClient. Alternatively perhaps exposing a function in raygun4go.go to accept a custom SendError routine which the consuming project then injects with a custom submit() function may be more flexible, but it would be nice if this could work out of the box of course. |
Hi , |
updated packages
Hey ,
As you can see in this therd raygun doesn't work on app engine becouse you cant use http.clinet insted you need to use url fetch.
In order yo use urlfetch you need to pass it appengin context .
If you don't pass anything it`s still work with the submit method.
this method will send the data to raygun .
Im not sure that's the best solution but lets work together to solve this issue