Addclient info to rum payload #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcythomas
reviewed
Sep 3, 2023
darcythomas
reviewed
Sep 4, 2023
darcythomas
previously approved these changes
Sep 7, 2023
Co-authored-by: Darcy <github@darcythomas.com>
Hamish-taylor
force-pushed
the
ht/add-client-data
branch
from
2001bb0
to
61b769b
Compare
added 2 commits
September 18, 2023 15:09
Co-authored-by: Sean Chapman <sean.b.chapman@gmail.com>
PanosNB
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is being developed in conjunction with updates to the RUM worker that allows for client information to be sent, This includes the name and version of the library.
This PR also patches a number of situations that could result in NaN values being sent to Raygun. The main areas changed are:
AddMissingWRTwere accessingoffsetwhich is not always set. This now falls back to zero if no value exists