Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue Where WeakReference Delegate is Garbage Collected While Client is Alive #529

Merged
merged 4 commits into from
May 9, 2024

Conversation

ProRedCat
Copy link
Contributor

Fixes an issue where the reference to the delegate that sends unhandled exceptions to the client is garbage collected despite the client being alive. This can cause uncaught exceptions not to be reported to Raygun.

This is fixed by adding a strong reference in the client so that while the client is alive the delegate should be alive too.

Copy link
Contributor

@phillip-haydon phillip-haydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 was writing to say you need change log but looks like you added it while i was afk :D

Copy link
Contributor

@xenolightning xenolightning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants