Support newer versions of psr/log #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psr/log 2.0 removes the TestLogger class, so I've added a dev dependency on colinodell/psr-testlogger, which exposes a compatible class.
|
Hi @edsrzf, thanks for the pull request. I think it would be better to replace the TestLogger implementation with PHPUnit mocks of the LoggerInterface class. Since PSR seem not to want that class any longer, replacing it with a polyfill seems like a band-aid solution. Would you be interested in making those updates? |
|
@robbieaverill done. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psr/log 2.0 removes the
TestLoggerclass, so I've replaced its usage with PHPUnit mocks.