Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add *BSD fix for ONLCR support #173

Merged
merged 2 commits into from Jul 11, 2017
Merged

add *BSD fix for ONLCR support #173

merged 2 commits into from Jul 11, 2017

Conversation

psi29a
Copy link
Member

@psi29a psi29a commented Jul 10, 2017

This should resolve #171

@sezero
Copy link
Contributor

sezero commented Jul 10, 2017

I wonder what is preventing __BSD_VISIBLE from being defined in the first place.

If we can't find that, then this looks like the next best thing for the time being
and gets no objections from me.

@psi29a
Copy link
Member Author

psi29a commented Jul 11, 2017 •
edited

Hmmm.... osx is failing, I think I know why (homebrew I'm looking at you and pkg-config). I'll fix this next.

@psi29a
Copy link
Member Author

psi29a commented Jul 11, 2017

I win!
Merging.

@psi29a psi29a merged commit 2e49573 into master Jul 11, 2017
@sezero sezero deleted the fix_freebsd_builds branch August 2, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezero sezero Awaiting requested review from sezero

@chrisisonwildcode chrisisonwildcode Awaiting requested review from chrisisonwildcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

freebsd build failure report
2 participants
@psi29a @sezero