Clamp MUS volume commands #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://doomwiki.org/wiki/MUS The MUS format allows for values above 127 to be present in files. Supposedly, the original DMX library would clamp them back down to 127. Without this behaviour, the song "Smells like Burning Corpse" from Final Doom has extremely loud instruments.
|
Cool, thanks for this. Yeah, I noticed that you have been working on your own doom game in a blog post where you have been using wildmidi. :D |
|
Could you perhaps add in comments as to why we clamp to 127, perhaps referencing this ticket? That way people can read why it is the way it is. |
|
Thanks. |
sezero
added a commit
to sezero/hheretic
that referenced
this pull request
Jan 7, 2021
https://doomwiki.org/wiki/MUS The MUS format allows for values above 127 to be present in files. Supposedly, the original DMX library would clamp them back down to 127. Without this behaviour, the song "Smells like Burning Corpse" from Final Doom has extremely loud instruments. Patch by Clownacy (Mindwerks/wildmidi#226) git-svn-id: svn://svn.code.sf.net/p/hhexen/code/trunk/hheretic@617 989aa981-fe4f-0410-aa6a-c19d413bcdcd
sezero
added a commit
to sezero/hhexen
that referenced
this pull request
Jan 7, 2021
https://doomwiki.org/wiki/MUS The MUS format allows for values above 127 to be present in files. Supposedly, the original DMX library would clamp them back down to 127. Without this behaviour, the song "Smells like Burning Corpse" from Final Doom has extremely loud instruments. Patch by Clownacy (Mindwerks/wildmidi#226) git-svn-id: svn://svn.code.sf.net/p/hhexen/code/trunk/hhexen@617 989aa981-fe4f-0410-aa6a-c19d413bcdcd
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here, the MUS format allows for values above 127 to be present in files. Supposedly, the original DMX library would clamp them back down to 127. Without this behaviour, the song "Smells like Burning Corpse" from Final Doom has extremely loud instruments.