-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add property decorators in World #209
Comments
It might not hurt if you added this to #207, if you could spare the time. By "add" I mean "create all necessary functions and then replace every use of any layer throughout the code with a call to the corresponding property". Also, do you need to explicitly create a setter, too? @property
def elevation(self):
return self.layers['elevation'].data
@elevation.setter
def elevation(self, value):
self.layers['elevation'].data = value |
Me and Bret discussed it and we would prefer to go by steps: so we first merge #207 and then introduce property decorators. I am not sure about the setters perhaps it could make sense given we had all those set_ocean, set_temperature methods to replace |
Thanks for this @tcld it is good plan. :) |
I'm going to convert to properties all functions that starts with |
For example:
The text was updated successfully, but these errors were encountered: