Fix validate install for fresh install from pip #105
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the usage of importlib_resources to use the files API
thomashopkins32
changed the title
This was referenced Nov 13, 2023
|
Very helpful! I can run this version directly (after setting Java to the officially recommended Java 8). Thanks! |
|
This worked for me as well. Thanks @thomashopkins32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR should fix
validate_install.pyfor anyone trying to install the package from pip in a new conda environment.It bumps the
gymversion to 0.22.0. This is needed since there is a typo insetup.pyin the 0.21.0 version ofgym.(the assertions were failing after I did this but this seems to be the only breaking change)
It fixes the version of
importlib_resourcessince their API changed. I updated the old method to use the new API.See #104 and #106 for the errors.
Thanks!
Closes #104
Closes #106