Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FireworkEffectMeta #69

Merged
merged 2 commits into from
May 19, 2024
Merged

FireworkEffectMeta #69

merged 2 commits into from
May 19, 2024

Conversation

BimboBigBoy
Copy link
Contributor

No description provided.

@BimboBigBoy BimboBigBoy requested a review from 0ffz as a code owner May 19, 2024 20:44
Boy0000
Boy0000 requested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@Boy0000 Boy0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FireworkEffectMeta is not the colorable part of this itemmeta
It is the FireworkEffect properties under the hood of it

@Boy0000 Boy0000 merged commit a3d2961 into MineInAbyss:master May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boy0000 Boy0000 Boy0000 approved these changes

@0ffz 0ffz Awaiting requested review from 0ffz 0ffz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BimboBigBoy @Boy0000