Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

最大方块交互距离更改时交互了两次 #46

Closed
2 tasks done
cdqtzrc opened this issue Nov 25, 2023 · 9 comments
Closed
2 tasks done

最大方块交互距离更改时交互了两次 #46

cdqtzrc opened this issue Nov 25, 2023 · 9 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@cdqtzrc
Copy link

cdqtzrc commented Nov 25, 2023

Bug description

最大方块交互距离启用时,拿着刷怪蛋点一下地面,生成了两只生物

Steps to reproduce

1.拿一个刷怪蛋
2.将最大方块交互距离改成一个较大值(最好大于6)
3.拿刷怪蛋点一下近处的地面

1.找到一个活板门方块
2.点击一下活板门

Expected behavior

生成一只生物

活板门打开

Actual behavior

生成了两只生物

活板门打开后立即关闭

Relevant logs

No response

Minecraft version

1.20.1

TemplateMod version

Carpet-AMS-Addition v2.14.1

Other information

解决方案:
屏幕截图 2023-11-25 194310
interactBlock()方法调用了两次,一次是距离小于64.0时正常调用的,另一次是距离小于AmsServerSettings.maxBlockInteractionDistance时调用的

Check list

  • I have verified that the issue persists in the latest version of the mod.
  • I have searched the existing issues and confirmed that this is not a duplicate.
@1024-byteeeee
Copy link
Collaborator

1024-byteeeee commented Nov 25, 2023

十分感谢,v2.14.1更新之后服里有人发现跟我说了然后更了v2.14.2🤣,不过我是这样解决的:
1(1)

@cdqtzrc
Copy link
Author

cdqtzrc commented Nov 25, 2023

但是还有一个小问题,在世界最高处以上放置方块时,会显示一条世界高度限制是319的警告信息,但是修改了交互距离后这条警告没有了

@1024-byteeeee
Copy link
Collaborator

但是还有一个小问题,在世界最高处以上放置方块时,会显示一条世界高度限制是319的警告信息,但是修改了交互距离后这条警告没有了

这应该不是一个值得注意的问题我感觉,因为建筑高度本身就是319,你怎么看。🤔

@cdqtzrc
Copy link
Author

cdqtzrc commented Nov 25, 2023

不想改就算了,毕竟这个bug并不严重

@1024-byteeeee
Copy link
Collaborator

不想改就算了,毕竟这个bug并不严重

是的,org carpet有计划做低版本支持吗,有的话如下部分我也要做对应修改....

1(1)

@cdqtzrc
Copy link
Author

cdqtzrc commented Nov 25, 2023

目前没有,估计以后也不会有

@1024-byteeeee
Copy link
Collaborator

目前没有,估计以后也不会有

那我暂时先不动了,虽然它有兼容性上的问题但是我感觉这里用 @ModifyConstant@Inject 更好。

@cdqtzrc
Copy link
Author

cdqtzrc commented Nov 25, 2023

还有件事,在提交这个bug之前我是看了更新日志的,但是你似乎没有把问题描述清除
image

@1024-byteeeee
Copy link
Collaborator

还有件事,在提交这个bug之前我是看了更新日志的,但是你似乎没有把问题描述清除 image

是的,现在看来我的描述应该是有错误的,这并不属于兼容性问题(因为成员发现后我随便放了两个方块只是快速放置会放两次,正常对地板放没有问题),我现在修改日志。

@1024-byteeeee 1024-byteeeee added the documentation Improvements or additions to documentation label Nov 25, 2023
@1024-byteeeee 1024-byteeeee added the bug Something isn't working label Nov 25, 2023
1024-byteeeee added a commit that referenced this issue Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants