Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some enhances for loops fixes and re-enable do-while loops #38

Merged
merged 1 commit into from Jun 20, 2020
Merged

Some enhances for loops fixes and re-enable do-while loops #38

merged 1 commit into from Jun 20, 2020

Conversation

JDLogic
Copy link
Member

@JDLogic JDLogic commented Oct 5, 2018 •
edited

  • Fix cases where a needed break was not inserted after a loop
  • Detect cases where a continue needed to be added after a loop
  • Fix cases where the body of an if statement was incorrectly extracted (preventing the formation of a for / foreach loop)
  • Re-enable the construction of do while loops

mc 1.16-rc1 Diff

@bs2609
Copy link

bs2609 commented Feb 5, 2019

This would fix #31, do you have any thoughts about #30?

@ichttt ichttt mentioned this pull request Jul 13, 2019
Closed
Chocohead added a commit to Chocohead/ForgedFlower that referenced this pull request Mar 10, 2020
@Chocohead
Merge in MinecraftForge/ForgeFlower#38 changes
4a39dcd
@JDLogic JDLogic changed the title Revisit loop fixes Some enhances for loops fixes and re-enable do-while loops Jun 13, 2020
@JDLogic
Copy link
Member Author

JDLogic commented Jun 13, 2020

Updated the title and diff. There are still same weird cases that need looking into, but this is a good start.

@JDLogic
Copy link
Member Author

JDLogic commented Jun 20, 2020

Rebased again, this should be ready.

@LexManos LexManos merged commit ed217ba into MinecraftForge:master Jun 20, 2020
@JDLogic JDLogic deleted the loops branch June 20, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JDLogic @bs2609 @LexManos