Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle 8.2+ #933

Closed
gmitch215 opened this issue Aug 15, 2023 · 6 comments
Closed

Support Gradle 8.2+ #933

gmitch215 opened this issue Aug 15, 2023 · 6 comments

Comments

@gmitch215
Copy link

gmitch215 commented Aug 15, 2023

If you upgrade the Gradle Wrapper to 8.2 or above, upon building this error appears:

java.lang.NoSuchMethodError: 'void org.gradle.api.internal.artifacts.repositories.descriptor.FlatDirRepositoryDescriptor.<init>(java.lang.String, java.util.Collection)'

It builds properly on Gradle 8.1.x. I believe this has to do with breaking changes in Gradle 8.2.

Edit: I saw #929 and created a linked issue at MinecraftForge/Artifactural#9

@LexManos
Copy link
Member

I can do another stopgap fix for this. But gradle is know to break a lot of things on a whim. So I'm currently rewriting the entire FG toolchain to not be as horrible as people have let it become. It's just a matter of development time.

For now, it's on my todo for a stopgap fix. But a low priority.

@gmitch215
Copy link
Author

LexManos

Any updates on this? Sorry for reviving this issue, but Gradle's been updated to 8.5, and there are a couple of API additions that make life easier. Is there a potential ETA?

@gmitch215 gmitch215 changed the title Support Gradle 8.2 Support Gradle 8.2+ Nov 29, 2023
@PaintNinja
Copy link
Contributor

It should work on 8.4 already and 8.5 isn't stable yet

@gmitch215
Copy link
Author

It should work on 8.4 already and 8.5 isn't stable yet

Gradle for 8.5 was released as stable about 11 hours ago. But thanks, I'll try it out when I get the chance.

@gmitch215
Copy link
Author

It should work on 8.4 already and 8.5 isn't stable yet

Still doesn't work:

> Failed to notify project evaluation listener.
   > 'void org.gradle.api.internal.artifacts.repositories.descriptor.FlatDirRepositoryDescriptor.<init>(java.lang.String, java.util.Collection)'
   > 'void org.gradle.api.internal.artifacts.repositories.descriptor.FlatDirRepositoryDescriptor.<init>(java.lang.String, java.util.Collection)'

@LexManos
Copy link
Member

Should be solved with #936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants