Fix classes javadoc breakage #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoDeveloping
force-pushed
the
classes_javadoc_fix
branch
4 times, most recently
from
7c38c27
to
c3bc2fe
Compare
|
What will it take to get this merged in? The bug (that this looks like it fixes) prevents "gradlew eclipse" from working in 1.13,2, 1.14.2, and 1.14.3. |
|
It is complete from my side, and with it setting up the MDK should work again (at least on 1.14.2, which I tested). |
JoJoDeveloping
force-pushed
the
classes_javadoc_fix
branch
from
c3bc2fe
to
454a9fe
Compare
This enables the Forum tag auto-closing and locking Issues and PRs, assuming the bot is watching the ForgeGradle repo
…nd also doesn't attempt to javadoc most classes
JoJoDeveloping
force-pushed
the
classes_javadoc_fix
branch
from
454a9fe
to
84412e2
Compare
|
Can you please rebase this on top of the You also don't need to pass the Logger object around just do |
covers1624
added
the
needs rebase
|
Closed as this is no longer up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in previous PR ( #617 )
We previously failed hard when we couldn't keep track of indentation. Now we just fail softly and warn the user that there is likely an issue with class javadoc comments.
We could also use "debug" or "info" instead of "warn" for the logger or just stop adding class javadocs when it fails, instead of trying to recover