Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fernflower, Mergetool and Renametool don't apply jvmargs #24

Closed
Marcono1234 opened this issue Oct 7, 2018 · 2 comments
Closed

Fernflower, Mergetool and Renametool don't apply jvmargs #24

Marcono1234 opened this issue Oct 7, 2018 · 2 comments
Labels
type: bug Something isn't working

Comments

@Marcono1234
Copy link
Contributor

The following jars allow specifying jvmargs in the config.json file, but do not apply them when running the task. Especially for fernflower this might be rather important.

This could probably be solved by adding jvmArgs <config>.jvmargs to the respective taks, for example

task renameClient(type: RemapJar, dependsOn: [downloadRenameTool, downloadLibraries, filterClient]) {
    jar downloadRenameTool.dest
    // Use jvmargs
    jvmArgs RENAMETOOL.jvmargs
    input filterClient.archivePath
    mappings file(PATH_VERSION + 'joined.tsrg')
    args RENAMETOOL.args
    dest file(PATH_CACHED_VERSION + project.version + '.client.mapped.jar')
}
@kashike
Copy link
Contributor

kashike commented Oct 10, 2018

Pull request?

@kashike
Copy link
Contributor

kashike commented Oct 10, 2018

#26

@kashike kashike closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants