Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coral Stuff #78

Closed
5 tasks done
Cyborgmas opened this issue Jun 6, 2020 · 1 comment
Closed
5 tasks done

Coral Stuff #78

Cyborgmas opened this issue Jun 6, 2020 · 1 comment
Labels
category: class Something involving a class type: question Further information is requested version: 1.17

Comments

@Cyborgmas
Copy link
Contributor

Cyborgmas commented Jun 6, 2020 •
edited

  • net/minecraft/block/CoralFinBlock -> LivingCoralFanBlock
  • net/minecraft/block/AbstractCoralPlantBlock -> CoralPlantBlock
  • net/minecraft/block/CoralPlantBlock -> LivingCoralPlantBlock
  • net/minecraft/block/DeadCoralWallFanBlock -> CoralWallFanBlock
  • net/minecraft/block/CoralWallFanBlock -> LivingCoralWallFanBlock

To better identify all the different coral blocks. See MCPConfig google sheet for more details
@Cyborgmas Cyborgmas mentioned this issue Jun 6, 2020
Closed
12 tasks
@LexManos LexManos added category: class Something involving a class type: question Further information is requested version: 1.17 labels Jun 10, 2020
@LexManos
Copy link
Member

LexManos commented Jun 10, 2020 •
edited

Needs more feedback, I don't see a benefit to the rename. We may be able to 'group' them together by moving them to block/coral? Maybe as a bigger 'block/item grouping'? Needs more discussion.

@LexManos LexManos closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: class Something involving a class type: question Further information is requested version: 1.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LexManos @Cyborgmas