Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FakePlayer.getMinecraft() doesn't follow the suggestions of FakePlayer.get() #1705

Closed
octylFractal opened this issue Feb 15, 2015 · 1 comment
Closed

FakePlayer.getMinecraft() doesn't follow the suggestions of FakePlayer.get() #1705

octylFractal opened this issue Feb 15, 2015 · 1 comment

Comments

@octylFractal
Copy link

FakePlayer.get() states:

Mods should either hold weak references to the return value, or listen for a WorldEvent.Unload and kill all references to prevent worlds staying in memory.

However, FakePlayer.getMinecraft() caches the value of the result and stores it in MINECRAFT_PLAYER, but then never unloads it upon world unload. The easiest solution is to do just that.
@octylFractal
Copy link
Author

Semi related: #892

@Ipsis Ipsis mentioned this issue Jan 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@octylFractal